[Pkg-utopia-maintainers] Bug#530024: Bug#530024: network-manager: suggested patch

[Michael Biebl]

On 03.10.2010 22:49, Raphael Hertzog wrote:
> tags 530024 + patch
> thanks
> 
> Hi, 
> 
> please find attached a patch based on what Ubuntu has done with a few
> improvements:
> - a single backup per run but the correct one
> - disable with a special prefix (to allow the next feature)
> - re-enable on removal
> 
> It's still somewhat crude, i.e. it's not something I would like to have on
> my own package but it works for now. You might also want to tweak the name
> of the backup files and maybe remove them on purge...

Hi Raphael,

thanks for the patch. A few comments:

a/ running the script will comment out the line
"iface ethX inet dhcp", but not "auto ethX" itself. Is that intentional? I'd say
commenting out all lines relating to ethX would be more logical

b/ I'd change the comment marker to something like
#<Disabled by NetworkManager># or #<Managed by NetworkManager>#

c/ I'm not sure if we should restore /etc/network/interfaces from the backup
file, as this file might have become out-of-sync with /etc/network/interface and
we overwrite changes that were made in between. The question is, if we even need
to create a backup file.
My suggestion would be, to simply remove the comment markers (inplace) for
/etc/network/interface on remove. This would ensure we preserve any local
modifications.
What do you think?


Other than that, it seems to do it's job just fine.

Thanks again,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-utopia-maintainers/attachments/20101020/715932f5/attachment.pgp>