[Pkg-utopia-maintainers] Bug#530024: Bug#530024: network-manager: suggested patch

[Raphael Hertzog]

Hi,

On Wed, 20 Oct 2010, Michael Biebl wrote:
> a/ running the script will comment out the line
> "iface ethX inet dhcp", but not "auto ethX" itself. Is that intentional? I'd say
> commenting out all lines relating to ethX would be more logical

The ubuntu script has a comment about this, so it's known/intentional but
it doesn't hurt AFAIK.

The problem with those auto lines is that you can have multiple interfaces
on the same line so you can't just disable the whole line unless you have
a single interface listed.

> b/ I'd change the comment marker to something like
> #<Disabled by NetworkManager># or #<Managed by NetworkManager>#

Put the value that you want.

> c/ I'm not sure if we should restore /etc/network/interfaces from the backup
> file, as this file might have become out-of-sync with /etc/network/interface and
> we overwrite changes that were made in between. The question is, if we even need
> to create a backup file.

> My suggestion would be, to simply remove the comment markers (inplace) for
> /etc/network/interface on remove. This would ensure we preserve any local
> modifications.
> What do you think?

This is already what the patch does. I have left the backup files for extra
safety but if you feel confident not creating them, I'm fine with this.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer ◈ [Flattr=20693]

Follow my Debian News ▶ http://RaphaelHertzog.com (English)
                      ▶ http://RaphaelHertzog.fr (Français)