[Pkg-utopia-maintainers] Bug#790341: network-manager: [regression] change in dnsmasq has broken connection sharing support

[Paul Wise]

Package: network-manager
Version: 1.0.2-2
Severity: important
Tags: patch

I sometimes share my WiFi connection to the Internet via Ethernet. A
recent upgrade of dnsmasq-base (I think 2.72-3.1+b1 to 2.73-1) on my
system broke this as dnsmasq now tries to read /etc/dnsmasq.conf when
--conf-file is given without any argument, with only dnsmasq-base, this
file is not present. The fix is to make it read /dev/null instead. I
verified that that works by diverting the dnsmasq binary and replacing
the --conf-file argument with a --conf-file=/dev/null argument.

src/dnsmasq-manager/nm-dnsmasq-manager.c:245
-	nm_cmd_line_add_string (cmd, "--conf-file");
+	nm_cmd_line_add_string (cmd, "--conf-file=/dev/null");

Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  Starting dnsmasq...
Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  (eth0): device state change: ip-config -> ip-check (reason 'none') [70 80 0]
Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  (eth0): Activation: Stage 5 of 5 (IPv4 Commit) complete.
Jun 28 16:04:19 chianamo NetworkManager[844]: dnsmasq --conf-file --no-hosts --keep-in-foreground --bind-interfaces --except-interface=lo --clear-on-reload --strict-order --listen-address=10.42.0.1 --dhcp-range=10.42.0.10,10.42.0.254,60m --dhcp-option=option:router,10.42.0.1 --dhcp-lease-max=50 --pid-file=/var/run/nm-dnsmasq-eth0.pid
Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  (eth0): device state change: ip-check -> secondaries (reason 'none') [80 90 0]
Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  (eth0): device state change: secondaries -> activated (reason 'none') [90 100 0]
Jun 28 16:04:19 chianamo NetworkManager[844]: dnsmasq: cannot read /etc/dnsmasq.conf: No such file or directory
Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  (eth0): Activation: successful, device activated.
Jun 28 16:04:19 chianamo NetworkManager[844]: <warn>  dnsmasq exited with error: Filesystem problem (missing file/directory; permissions; etc) (3)
Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  (eth0): device state change: activated -> failed (reason 'sharing-start-failed') [100 120 18]
Jun 28 16:04:19 chianamo NetworkManager[844]: <warn>  (eth0): Activation: failed for connection 'Ethernet (shared)'
Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  (eth0): device state change: failed -> disconnected (reason 'none') [120 30 0]
Jun 28 16:04:19 chianamo NetworkManager[844]: <info>  (eth0): deactivating device (reason 'none') [0]

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (900, 'testing'), (860, 'testing-proposed-updates'),
(850, 'buildd-testing-proposed-updates'), (800, 'unstable'), (790,
'buildd-unstable'), (700, 'experimental'), (690, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.0.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages network-manager depends on:
ii  adduser                3.113+nmu3
ii  dbus                   1.8.18-1
ii  init-system-helpers    1.23
ii  isc-dhcp-client        4.3.2-1
ii  libbluetooth3          5.23-2+b1
ii  libc6                  2.19-18
ii  libdbus-1-3            1.8.18-1
ii  libdbus-glib-1-2       0.102-1
ii  libgcrypt20            1.6.3-2
ii  libglib2.0-0           2.44.1-1
ii  libgnutls-deb0-28      3.3.15-7
ii  libgudev-1.0-0         230-1
ii  libmm-glib0            1.4.8-1
ii  libndp0                1.4-2
ii  libnewt0.52            0.52.17-1+b1
ii  libnl-3-200            3.2.24-2
ii  libnl-genl-3-200       3.2.24-2
ii  libnl-route-3-200      3.2.24-2
ii  libnm0                 1.0.2-2
ii  libpam-systemd         220-7
ii  libpolkit-agent-1-0    0.105-8
ii  libpolkit-gobject-1-0  0.105-8
ii  libreadline6           6.3-8+b3
ii  libsoup2.4-1           2.50.0-2
ii  libsystemd0            220-7
ii  libteamdctl0           1.17-1
ii  libuuid1               2.26.2-6
ii  lsb-base               4.1+Debian13+nmu1
ii  policykit-1            0.105-8
ii  udev                   220-7
ii  wpasupplicant          2.3-2

Versions of packages network-manager recommends:
ii  crda            3.13-1
ii  dnsmasq-base    2.73-1
ii  iptables        1.4.21-2+b1
ii  iputils-arping  3:20121221-5+b2
ii  modemmanager    1.4.8-1
ii  ppp             2.4.6-3.1

Versions of packages network-manager suggests:
ii  avahi-autoipd  0.6.31-5
pn  libteam-utils  <none>

-- no debconf information

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-utopia-maintainers/attachments/20150628/666f0fe5/attachment.sig>