[Pkg-utopia-maintainers] Bug#1043322: cockpit-tests: prone to loosing /lib/systemd/system/cockpit.service.d during /usr-merge

[Helmut Grohne]

Package: cockpit-tests
Version: 297-1
Severity: important
Tags: patch upstream

Hi,

cockpit-tests has a non-trivial aspect when it comes to finalizing the
/usr-merge. As we move all files from / to /usr, we'll likely also move
/lib/systemd/system/cockpit.service.d. Such a move is currently
prevented by the CTTE moratorium, but we are preparing for lifting that
and this bug is part of that preparation. When performing that move for
cockpit-tests, dpkg will delete this particular directory during package
upgrade. Thus the dpkg database will be inconsistent with the actual
filesystem, which generally is a bad outcome.

Don't panic. We're lucky and cockpit does not actually need this
directory. The tests actually use /etc/systemd/system/cockpit.service.d,
so the affected location is entirely unused and we can simply delete it.
Once deleted, there cannot be an inconsistency between dpkg database and
filesystem as both agree it to be absent. So removing it now will save
us trouble later. This removal is not prohibited by the moratorium and
can be implemented without waiting.

I'm attaching a patch for your convenience and hope you agree.

This report does not imply that cockpit is unaffected by other issues
related to the /usr-merge. It merely asks for removing this single
instance that is well understood and actionable now.

Helmut