[Pkg-utopia-maintainers] Bug#1043322: cockpit-tests: prone to loosing /lib/systemd/system/cockpit.service.d during /usr-merge

[Martin Pitt]

Control: forwarded -1 https://github.com/cockpit-project/cockpit/pull/19188

Hello Helmut,

Helmut Grohne [2023-08-08 12:38 +0200]:
> cockpit-tests has a non-trivial aspect when it comes to finalizing the
> /usr-merge. As we move all files from / to /usr, we'll likely also move
> /lib/systemd/system/cockpit.service.d. Such a move is currently
> prevented by the CTTE moratorium, but we are preparing for lifting that
> and this bug is part of that preparation. When performing that move for
> cockpit-tests, dpkg will delete this particular directory during package
> upgrade. Thus the dpkg database will be inconsistent with the actual
> filesystem, which generally is a bad outcome.

Thanks for pointing this out! I'm all for clearing up all obstacles for getting
usrmerge over the line at last. I wasn't even aware that we ship that
directory. https://packages.debian.org/sid/amd64/cockpit-tests/filelist
doesn't have it, but I suppose that doesn't show empty directories.

> I'm attaching a patch for your convenience and hope you agree.

You didn't actually, but it's fairly straightforward (I think). I sent an
upstream PR to fix that. I didn't test it at all, let's see what CI says -- but
I'm fairly sure about it.

If all goes well, that can go into today's release, then I can fix this in sid
in the next day or two.

Cheers!

Martin