Bug#984382: vdr: ftbfs with GCC-11

[Matthias Klose]

Package: src:vdr
Version: 2.4.1-4.1
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/vdr_2.4.1-4.1_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from tools.h:18,
                 from i18n.h:14,
                 from config.h:19,
                 from channels.h:13,
                 from channels.c:10:
/usr/include/c++/11/bits/stl_algobase.h:300:5: note: ‘std::max’ declared here
  300 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
channels.c: In static member function ‘static int cChannels::MaxShortChannelNameLength()’:
channels.c:1061:41: error: ‘max’ was not declared in this scope; did you mean ‘std::max’?
 1061 |             maxShortChannelNameLength = max(Utf8StrLen(Channel->ShortName(true)), maxShortChannelNameLength);
      |                                         ^~~
      |                                         std::max
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from tools.h:18,
                 from i18n.h:14,
                 from config.h:19,
                 from channels.h:13,
                 from channels.c:10:
/usr/include/c++/11/bits/stl_algobase.h:300:5: note: ‘std::max’ declared here
  300 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
ci.c: In member function ‘virtual void cCaPidReceiver::Receive(const uchar*, int)’:
ci.c:216:17: error: ‘min’ was not declared in this scope; did you mean ‘std::min’?
  216 |         int n = min(length, TS_SIZE - 4);
      |                 ^~~
      |                 std::min
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from tools.h:18,
                 from i18n.h:14,
                 from config.h:19,
                 from channels.h:13,
                 from ci.h:15,
                 from ci.c:10:
/usr/include/c++/11/bits/stl_algobase.h:278:5: note: ‘std::min’ declared here
  278 |     min(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
ci.c: In member function ‘bool cCiMMI::SendAnswer(const char*)’:
ci.c:1596:12: error: ‘min’ was not declared in this scope; did you mean ‘std::min’?
 1596 |      len = min(sizeof(answer.text), strlen(Text));
      |            ^~~
      |            std::min
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from tools.h:18,
                 from i18n.h:14,
                 from config.h:19,
                 from channels.h:13,
                 from ci.h:15,
                 from ci.c:10:
/usr/include/c++/11/bits/stl_algobase.h:278:5: note: ‘std::min’ declared here
  278 |     min(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
make[2]: *** [Makefile:135: channels.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:135: ci.o] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 "INSTALL=install --strip-program=true" PREFIX=/usr VIDEODIR=/var/lib/video LIBDIR=/usr/lib/vdr/plugins SDNOTIFY=1 VERBOSE=1 returned exit code 2
make[1]: *** [debian/rules:17: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:14: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2