Bug#984383: vdr-plugin-dvbhddevice: ftbfs with GCC-11

[Matthias Klose]

Package: src:vdr-plugin-dvbhddevice
Version: 2.2.0-13
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/vdr-plugin-dvbhddevice_2.2.0-13_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]

Command: dpkg-buildpackage -us -uc -b -rfakeroot
dpkg-buildpackage: info: source package vdr-plugin-dvbhddevice
dpkg-buildpackage: info: source version 2.2.0-13
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Tobias Grimm <etobi at debian.org>
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean --with vdrplugin
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_auto_clean
dh_auto_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
	make -j1 clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_clean
dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
 debian/rules build
dh build --with vdrplugin
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_update_autotools_config
   dh_auto_configure
dh_auto_configure: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_auto_build
dh_auto_build: warning: Compatibility levels before 10 are deprecated (level 9 in use)
	make -j1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
g++ -g -O2 -fdebug-prefix-map=/build/vdr-J3eFss/vdr-2.4.1=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -c -DPLUGIN_NAME_I18N='"dvbhddevice"'  -o dvbhddevice.o dvbhddevice.c
g++ -g -O2 -fdebug-prefix-map=/build/vdr-J3eFss/vdr-2.4.1=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -c -DPLUGIN_NAME_I18N='"dvbhddevice"'  -o dvbhdffdevice.o dvbhdffdevice.c
g++ -g -O2 -fdebug-prefix-map=/build/vdr-J3eFss/vdr-2.4.1=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -c -DPLUGIN_NAME_I18N='"dvbhddevice"'  -o hdffcmd.o hdffcmd.c
g++ -g -O2 -fdebug-prefix-map=/build/vdr-J3eFss/vdr-2.4.1=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -c -DPLUGIN_NAME_I18N='"dvbhddevice"'  -o hdffosd.o hdffosd.c
hdffosd.c: In member function ‘virtual void cHdffOsd::DrawText(int, int, const char*, tColor, tColor, const cFont*, int, int, int)’:
hdffosd.c:352:26: error: ‘max’ was not declared in this scope; did you mean ‘std::max’?
  352 |                     x += max(h / TEXT_ALIGN_BORDER, 1);
      |                          ^~~
      |                          std::max
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from /usr/include/vdr/tools.h:18,
                 from /usr/include/vdr/i18n.h:14,
                 from /usr/include/vdr/config.h:19,
                 from /usr/include/vdr/osd.h:16,
                 from hdffosd.h:10,
                 from hdffosd.c:7:
/usr/include/c++/11/bits/stl_algobase.h:300:5: note: ‘std::max’ declared here
  300 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
hdffosd.c:361:26: error: ‘max’ was not declared in this scope; did you mean ‘std::max’?
  361 |                     x -= max(h / TEXT_ALIGN_BORDER, 1);
      |                          ^~~
      |                          std::max
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from /usr/include/vdr/tools.h:18,
                 from /usr/include/vdr/i18n.h:14,
                 from /usr/include/vdr/config.h:19,
                 from /usr/include/vdr/osd.h:16,
                 from hdffosd.h:10,
                 from hdffosd.c:7:
/usr/include/c++/11/bits/stl_algobase.h:300:5: note: ‘std::max’ declared here
  300 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
make[1]: *** [Makefile:65: hdffosd.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:7: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2