Bug#984395: vdr-plugin-vcd: ftbfs with GCC-11

[Matthias Klose]

Package: src:vdr-plugin-vcd
Version: 0.9-28
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/vdr-plugin-vcd_0.9-28_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
dh clean --with vdrplugin
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   debian/rules override_dh_auto_clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make -o .dependencies clean VDRDIR=/usr/include/vdr LIBDIR=. LOCALEDIR=locale
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
rm -rf locale libvdr-*.so.*
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_clean
dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
 debian/rules build
dh build --with vdrplugin
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_update_autotools_config
   dh_auto_configure
dh_auto_configure: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_build -- all VDRDIR=/usr/include/vdr LIBDIR=. LOCALEDIR=locale
dh_auto_build: warning: Compatibility levels before 10 are deprecated (level 9 in use)
	make -j1 all VDRDIR=/usr/include/vdr LIBDIR=. LOCALEDIR=locale
make[2]: Entering directory '/<<PKGBUILDDIR>>'
g++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -c -DPLUGIN_NAME_I18N='"vcd"' -D_GNU_SOURCE -I/usr/include/vdr/include vcd.c
vcd.c: In member function ‘virtual cOsdMenu* cPluginVcd::MainMenuAction()’:
vcd.c:139:20: error: ‘max’ was not declared in this scope; did you mean ‘std::max’?
  139 |         psd_size = max((int)U32_TO_LE(vcd->vcdInfo.psd_size), PSD_VCD_MAX_SIZE*CD_XA21_DATASIZE);
      |                    ^~~
      |                    std::max
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from /usr/include/vdr/tools.h:18,
                 from /usr/include/vdr/i18n.h:14,
                 from /usr/include/vdr/config.h:19,
                 from /usr/include/vdr/interface.h:13,
                 from vcd.c:25:
/usr/include/c++/11/bits/stl_algobase.h:300:5: note: ‘std::max’ declared here
  300 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
vcd.c:143:20: error: ‘max’ was not declared in this scope; did you mean ‘std::max’?
  143 |         psd_size = max((int)U32_TO_LE(vcd->vcdInfo.psd_size), PSD_VCD_MAX_SIZE*CD_XA21_DATASIZE);
      |                    ^~~
      |                    std::max
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from /usr/include/vdr/tools.h:18,
                 from /usr/include/vdr/i18n.h:14,
                 from /usr/include/vdr/config.h:19,
                 from /usr/include/vdr/interface.h:13,
                 from vcd.c:25:
/usr/include/c++/11/bits/stl_algobase.h:300:5: note: ‘std::max’ declared here
  300 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
vcd.c: In member function ‘virtual const char* cPluginVcd::Description()’:
vcd.c:73:14: warning: ignoring return value of ‘int asprintf(char**, const char*, ...)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   73 |      asprintf(&buf, "%s (%s)", DESCRIPTION, option_vcd);
      |      ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vcd.c: In member function ‘virtual const char* cPluginVcd::MainMenuEntry()’:
vcd.c:121:17: warning: ignoring return value of ‘int asprintf(char**, const char*, ...)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  121 |         asprintf(&buf, "%s (%s)", tr(MAINMENUENTRY), option_vcd);
      |         ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:61: vcd.o] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 all VDRDIR=/usr/include/vdr LIBDIR=. LOCALEDIR=locale returned exit code 2
make[1]: *** [debian/rules:13: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:10: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2