Bug#984396: vdr-plugin-xine: ftbfs with GCC-11

[Matthias Klose]

Package: src:vdr-plugin-xine
Version: 0.9.4-17
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/vdr-plugin-xine_0.9.4-17_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
g++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -g -O2 -fdebug-prefix-map=/build/vdr-J3eFss/vdr-2.4.1=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -c -D_GNU_SOURCE -DPLUGIN_NAME_I18N='"xine"' -DFIFO_DIR=\"/tmp/vdr-xine\" -DVERIFY_BITMAP_DIRTY=0 -DSET_VIDEO_WINDOW `pkg-config --cflags libxine`  -I/usr/include/vdr/include vdr172h264parser.c
xgettext -C -cTRANSLATORS --no-wrap --no-location -k -ktr -ktrNOOP --package-name=vdr-xine --package-version=0.9.4 --msgid-bugs-address='Reinhard Nissl <rnissl at gmx.de>' -o po/xine.pot vdr172h264parser.c vdr172remux.c xine.c xineDevice.c xineExternal.c xineLib.c xineOsd.c xineRemote.c xineSettings.c xineSetupPage.c xineplayer.c
g++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -g -O2 -fdebug-prefix-map=/build/vdr-J3eFss/vdr-2.4.1=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -c -D_GNU_SOURCE -DPLUGIN_NAME_I18N='"xine"' -DFIFO_DIR=\"/tmp/vdr-xine\" -DVERIFY_BITMAP_DIRTY=0 -DSET_VIDEO_WINDOW `pkg-config --cflags libxine`  -I/usr/include/vdr/include xineplayer.c
vdr172remux.c: In member function ‘void vdr172::cTsToPes::PutTs(const uchar*, int)’:
vdr172remux.c:3370:13: error: ‘max’ was not declared in this scope; did you mean ‘std::max’?
 3370 |      size = max(KILOBYTE(2), length + Length);
      |             ^~~
      |             std::max
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from /usr/include/vdr/tools.h:18,
                 from /usr/include/vdr/i18n.h:14,
                 from /usr/include/vdr/config.h:19,
                 from vdr172remux.c:2:
/usr/include/c++/11/bits/stl_algobase.h:300:5: note: ‘std::max’ declared here
  300 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
vdr172remux.c: In member function ‘const uchar* vdr172::cTsToPes::GetPes(int&)’:
vdr172remux.c:3390:17: error: ‘min’ was not declared in this scope; did you mean ‘std::min’?
 3390 |         int l = min(length - offset, MAXPESLENGTH);
      |                 ^~~
      |                 std::min
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from /usr/include/vdr/tools.h:18,
                 from /usr/include/vdr/i18n.h:14,
                 from /usr/include/vdr/config.h:19,
                 from vdr172remux.c:2:
/usr/include/c++/11/bits/stl_algobase.h:278:5: note: ‘std::min’ declared here
  278 |     min(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
vdr172remux.c: In function ‘void vdr172::TsDump(const char*, const u_char*, int)’:
vdr172remux.c:3433:11: error: ‘min’ was not declared in this scope; did you mean ‘std::min’?
 3433 |   int n = min(Length, 20);
      |           ^~~
      |           std::min
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from /usr/include/vdr/tools.h:18,
                 from /usr/include/vdr/i18n.h:14,
                 from /usr/include/vdr/config.h:19,
                 from vdr172remux.c:2:
/usr/include/c++/11/bits/stl_algobase.h:278:5: note: ‘std::min’ declared here
  278 |     min(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
vdr172remux.c:3438:10: error: ‘max’ was not declared in this scope; did you mean ‘std::max’?
 3438 |      n = max(n, Length - 10);
      |          ^~~
      |          std::max
In file included from /usr/include/c++/11/bits/specfun.h:45,
                 from /usr/include/c++/11/cmath:1927,
                 from /usr/include/c++/11/math.h:36,
                 from /usr/include/vdr/tools.h:18,
                 from /usr/include/vdr/i18n.h:14,
                 from /usr/include/vdr/config.h:19,
                 from vdr172remux.c:2:
/usr/include/c++/11/bits/stl_algobase.h:300:5: note: ‘std::max’ declared here
  300 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
make[2]: *** [Makefile:105: vdr172remux.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 all VDRDIR=/usr/include/vdr LIBDIR=. LOCALEDIR=debian/tmp/usr/share/locale VDR_XINE_SET_VIDEO_WINDOW=1 returned exit code 2
make[1]: *** [debian/rules:15: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:12: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2