zaptel: ztmonitor etc. not deleted

Tzafrir Cohen tzafrir.cohen@xorcom.com
Sun, 13 Mar 2005 22:30:41 +0200


On Sun, Mar 13, 2005 at 09:05:05PM +0100, Kilian Krause wrote:
> Hi Tzafrir,
> 
> Am Sonntag, den 13.03.2005, 21:55 +0200 schrieb Tzafrir Cohen:
> > Hi
> > 
> > I got the following errors when trying to build zaptel:
> > 
> > dpkg-source: cannot represent change to ztmonitor: binary file contents changed
> > dpkg-source: cannot represent change to ztspeed: binary file contents changed
> > dpkg-source: cannot represent change to zttest: binary file contents changed
> > 
> > Indeed the makefile had not instructions to delete it in the 'clean'
> > target. I then tried to edit the Makefile patch, only to figure out the
> > patch is being unapplied before calling $(MAKE) clean.
> > 
> > A quick fix:
> > add to the 'clean' in debian/rules:
> > 
> > 	rm -f fxstest ztmonitor ztspeed zttest
> 
> yes, broken clean targets from upstreams are quite common nowadays.

Again: the breakage is by Debian:

Debina's Makefile patch adds building ztmonitor zttest and ztspeed by
default (unlike upstream). Upstream's clean does not delete them because
it did not build them. The Debian patch to the makefile adds the lines
to delete those lines on 'make clean'

Debian's patch, however, is deapplied before 'make clean' is called,
leaving us with the upstream 'clean'.

-- 
Tzafrir Cohen     icq#16849755  +972-50-7952406
tzafrir.cohen@xorcom.com  http://www.xorcom.com