asterisk dapper.2114_to_dapper.2234 diff

[Jonas Smedegaard]

On Mon, 7 Aug 2006 10:23:07 +0300 Diego Iastrubni wrote:

> +###################################
> +# this part should be reviewed, but it's basically trial and error
> +# code i wrote to make freepbx work. better solutions are welcomed.
> +
>  # files need to be RW by the group
>  # dirs need to a+rx
> -#chmod -R 0664 /etc/asterisk/
> +#chmod -R 0660 /etc/asterisk/

This one should certainly be enabled, I suspect!


>  #find /etc/asterisk/ -type d | xargs chmod a+rx
> -#chmod +t /etc/asterisk/
> +#chmod g+s /etc/asterisk/

This looks odd to me. Both old and new command. Please elaborate.


>  # this is needed because othewise sqlite cannot write to the DB
> -#chmod -R 0660 /var/lib/asterisk/
> +# chmod -R 0660 /var/lib/asterisk/

Why indent?


> +	    invoke-rc.d asterisk start || exit $?
> +	fi
> +fi
> \ No newline at end of file

Please make sure there's a newline - just for the purity :-)


> +asterisk (1:1.2.10.dfsg-4) UNRELEASED; urgency=low
> +
> +  * asterisk_fix is included on the main asterisk package (should
> fix #287025, #360233, )
> +  * Vaiours fixes to asterisk_fix

Vaiours -> Various


> Index: rules
> ===================================================================
> --- rules	(revision 2189)
> +++ rules	(working copy)
> @@ -159,6 +159,10 @@
>  	# in the sample configs:
>  	cp -a debian/ast_config/* $(CURDIR)/debian/tmp/etc/asterisk
>  	
> +	mkdir -p $(CURDIR)/debian/asterisk/usr/share/asterisk/bin
> +	cp debian/asterisk_fix
> $(CURDIR)/debian/asterisk/usr/share/asterisk/bin
> +	chmod +x
> $(CURDIR)/debian/asterisk/usr/share/asterisk/bin/asterisk_fix
> +	
>  	mkdir -p $(CURDIR)/debian/tmp/usr/share/asterisk/firmware/iax
>  	cp contrib/firmware/iax/*.bin
> $(CURDIR)/debian/tmp/usr/share/asterisk/firmware/iax 


Did you remember to invoke the script from asterisk postinst?

And why provide as a separate script, if only relevant in the asterisk
postinst?

I mean, if the purpose of the script is not only to correct mess done
by earlier packaging, but general fixup of whatever the local user may
mess about, then it is certainly too limited now ;-)


 - Jonas

-- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

 - Enden er nær: http://www.shibumi.org/eoti.htm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20060807/f46e668f/attachment.pgp