[iaxmodem REMOVED from testing]

[Bernhard Schmidt]

On 16.03.2018 10:44, Joerg Dorchain wrote:

Hi Joerg,

> On Thu, Mar 01, 2018 at 09:13:57AM +0100, Bernhard Schmidt wrote:
>> If you are ready for upload please do a final adjustment of the
>> changelog (s/UNRELEASED/unstable/, current date, possibly fix the
>> autogenerated host-based email in the changelog signature) and ping me
>> again.
> 
> I created a 1.3.0 branch on salsa for the new upstream version
> and put the package in.
> At least, it builds and works for me(tm).
> 
> This fixes the remaining bugs and also the two items in action
> needed marked high (well, at least, the new upstream does not
> come with a potential array-out-of-bounds at the same location)
> 
> I would appreciate a review.
> 
> When this is ok, I would make the branch the new master and
> remove it after merging.

I've taken a look at your package.

First of all (probably caused by you not wanting to pollute the standard
branches, which is a good thing) the repo does not really adhere to the
normal git-buildpackage standards. Your have directly imported the new
upstream version into the master/1.3.0 branch. You should import it in
the upstream branch and then merge the upstream branch into your target
branch.

gbp import-orig

should do the right thing.

Other than that, please fix the few lintian errors

W: iaxmodem source: debian-rules-should-not-set-CFLAGS-from-noopt
W: iaxmodem: debian-changelog-has-wrong-day-of-week 2018-03-15 is a Thursday
E: iaxmodem: init.d-script-needs-depends-on-lsb-base etc/init.d/iaxmodem
(line 22)

Regarding the debian-rules-should-not-set-CFLAGS-from-noopt you could
probably drop the whole CFLAGS section. It will use the ones defined by
dpkg-buildflags then, which enable some hardening and FTBFS due to a
format-security error

iax2-parser.c: In function 'internaloutput':
iax2-parser.c:59:2: error: format not a string literal and no format
arguments [-Werror=format-security]
  printf(str);
  ^~~~~~

This (and other errors that are raised after this) should be fixed.

Bernhard