[iaxmodem REMOVED from testing]

[Joerg Dorchain]

On Mon, Mar 19, 2018 at 10:11:42PM +0100, Bernhard Schmidt wrote:
> 
> I've taken a look at your package.

Thanks!
> 
> First of all (probably caused by you not wanting to pollute the standard
> branches, which is a good thing) the repo does not really adhere to the
> normal git-buildpackage standards. Your have directly imported the new
> upstream version into the master/1.3.0 branch. You should import it in
> the upstream branch and then merge the upstream branch into your target
> branch.
> 
> gbp import-orig
> 
> should do the right thing.

I did not know that tool. Naively using it in my default branach I
probably messed up my repos. Can you maybe help me a bit with
proper use?

- Cechkout current master anew.
- Then do the gbp import-orig
- Then adapt the debian directory

Is this correct?

> Other than that, please fix the few lintian errors
> 
> W: iaxmodem source: debian-rules-should-not-set-CFLAGS-from-noopt

Please see below.

> W: iaxmodem: debian-changelog-has-wrong-day-of-week 2018-03-15 is a Thursday

Ooops, sorry.

> E: iaxmodem: init.d-script-needs-depends-on-lsb-base etc/init.d/iaxmodem
> (line 22)

Sure.

> 
> Regarding the debian-rules-should-not-set-CFLAGS-from-noopt you could
> probably drop the whole CFLAGS section. It will use the ones defined by
> dpkg-buildflags then, which enable some hardening and FTBFS due to a

I will give it a try if it still works for me after hardening
applied. If yes, I have no objections.

> format-security error
> 
> iax2-parser.c: In function 'internaloutput':
> iax2-parser.c:59:2: error: format not a string literal and no format
> arguments [-Werror=format-security]
>   printf(str);
>   ^~~~~~
> 
> This (and other errors that are raised after this) should be fixed.

Sure. I will try a local lintian before next call for review.

Bye,

Joerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20180320/9dac8d23/attachment.sig>