Bug#917467: wmbiff: tlscomm_expect() does not handle EAGAIN or GNUTLS_E_AGAIN

Andreas Metzler ametzler at bebt.de
Sun Feb 17 16:49:27 GMT 2019

On 2019-02-13 Nye Liu <nyet at nyet.org> wrote:
> On February 13, 2019 9:54:12 AM PST, Andreas Metzler <ametzler at bebt.de> wrote:
>> I am not sure about the second part of the patch. I understand wmbiff
>> breaking on GNUTLS_E_AGAIN from gnutls_read, because this only started
>> to happen recently (with TLS1.3) on blocking sockets.

>> What I do not get from my rudimentary understanding C programmimg is
>> the second part, this is in the else of "if (scs->tls_state)", so,
>> afaiui for non-encrypted connections. Is the change necessary there
>> at all, is it the right thing to retry read on EAGAIN then?

> Probably not, unless some other code change changes the conventional
> fd to no block. I added it only for symmetry sake. It does not fix any
> currently known bug. 

Doug, when there is no actual benefit for this part I would drop
it. - What do you think?

cu Andreas

`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

More information about the Pkg-wmaker-devel mailing list