Bug#917467: wmbiff: tlscomm_expect() does not handle EAGAIN or GNUTLS_E_AGAIN

Torrance, Douglas dtorrance at piedmont.edu
Sun Feb 17 18:24:53 GMT 2019

On 2/17/19 11:49 AM, Andreas Metzler wrote:
> On 2019-02-13 Nye Liu <nyet at nyet.org> wrote:
>> On February 13, 2019 9:54:12 AM PST, Andreas Metzler <ametzler at bebt.de> wrote:
>>> I am not sure about the second part of the patch. I understand wmbiff
>>> breaking on GNUTLS_E_AGAIN from gnutls_read, because this only started
>>> to happen recently (with TLS1.3) on blocking sockets.
>>> What I do not get from my rudimentary understanding C programmimg is
>>> the second part, this is in the else of "if (scs->tls_state)", so,
>>> afaiui for non-encrypted connections. Is the change necessary there
>>> at all, is it the right thing to retry read on EAGAIN then?
>> Probably not, unless some other code change changes the conventional
>> fd to no block. I added it only for symmetry sake. It does not fix any
>> currently known bug.
> Doug, when there is no actual benefit for this part I would drop
> it. - What do you think?

That sounds good to me.  I'll patch it upstream first and let you know 
when a new version of the Debian package is in git.


More information about the Pkg-wmaker-devel mailing list