Wmail Salsa Repo

[Andreas Metzler]

On 2019-06-15 Jeremy Sowden <jeremy at azazel.net> wrote:
> On 2019-06-09, at 11:26:15 +0100, Jeremy Sowden wrote:
>> I created a repo for wmail:

>>   https://salsa.debian.org/wmaker-team/wmail

>> [...]

>> I've used gbp plus quilt for the packaging.  I've imported the 2.1
>> upstream release.  I've got a few more changes to push before it is
>> ready for review.

> I've imported 2.2 and pushed that as well.

Hello Jeremy,

thank you!

> I think it's now ready for review, so when you have a moment, would
> you mind casting an eye over it?

1. it does not build in a minimal chroot:

./configure: line 3839: syntax error near unexpected token `X11,'
./configure: line 3839: `PKG_CHECK_MODULES(X11, x11)'


Installing pkg-config gets one step further
----------
checking for X11... yes
checking for dockapp... no
configure: error: Package requirements (dockapp) were not met:

Package 'xext', required by 'dockapp', not found
----------

The latter is not necessarily a wmail bug (See
https://bugs.debian.org/930603). You can either wait for a
fix/explanation there or work around the issue temporarily by adding a
b-d on libxext-dev.

2. Lintian warns about the empty line at the end of the changelog
(file-contains-trailing-whitespace debian/changelog (line 81))

3. debian/patches/0001-Removed-configure-and-Makefile.ins.patch can be
dropped - It does not serve any purpose because these files are
regenerated by dh_autoreconf.

cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'