Wmail Salsa Repo

[Jeremy Sowden]

On 2019-06-16, at 13:49:36 +0200, Andreas Metzler wrote:
> On 2019-06-15 Jeremy Sowden <jeremy at azazel.net> wrote:
> > On 2019-06-09, at 11:26:15 +0100, Jeremy Sowden wrote:
> >> I created a repo for wmail:
>
> >>   https://salsa.debian.org/wmaker-team/wmail
>
> >> [...]
>
> >> I've used gbp plus quilt for the packaging.  I've imported the 2.1
> >> upstream release.  I've got a few more changes to push before it is
> >> ready for review.
>
> > I've imported 2.2 and pushed that as well.
>
> Hello Jeremy,
>
> thank you!

Thanks for the review!

> > I think it's now ready for review, so when you have a moment, would
> > you mind casting an eye over it?
>
> 1. it does not build in a minimal chroot:
>
> ./configure: line 3839: syntax error near unexpected token `X11,'
> ./configure: line 3839: `PKG_CHECK_MODULES(X11, x11)'
>
>
> Installing pkg-config gets one step further
> ----------
> checking for X11... yes
> checking for dockapp... no
> configure: error: Package requirements (dockapp) were not met:
>
> Package 'xext', required by 'dockapp', not found
> ----------
>
> The latter is not necessarily a wmail bug (See
> https://bugs.debian.org/930603). You can either wait for a
> fix/explanation there or work around the issue temporarily by adding a
> b-d on libxext-dev.

Whoops.  Should have tested that.  Fixed.

> 2. Lintian warns about the empty line at the end of the changelog
> (file-contains-trailing-whitespace debian/changelog (line 81))

Fixed.

I've also fixed the other "lintian --pedantic" warnings:

  * added a home-page,
  * converted debian/copyright to DEP-5.

> 3. debian/patches/0001-Removed-configure-and-Makefile.ins.patch can be
> dropped - It does not serve any purpose because these files are
> regenerated by dh_autoreconf.

I put this in so that there were no uncommitted changes after building
the package, but I've taken it out.

I've pushed 2.2-3.

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-wmaker-devel/attachments/20190616/aa59afcd/attachment.sig>