[Pkg-zfsonlinux-devel] Current status?

Darik Horn dajhorn at vanadac.com
Tue May 7 00:05:29 UTC 2013

On Mon, May 6, 2013 at 4:03 PM, Carlos Alberto Lopez Perez
<clopez at igalia.com> wrote:
> We agreed to use your repository as base (which I didn't liked) and to
> ask you for review each commit before merging it with the idea that you
> could feel comfortable and you will engage in collaborating with me.

Do you know how I pounced on your ITP so quickly?

ZoL is high profile, and I was notified that you copied my work
without attribution into your initial submission.  I like to think
that Debian preserved my git history to give me some credit and
concession for that slight oversight.

> The one that was supposed to do code reviews was you, but you just
> ignored all merge request I sent to you. Aron just limited himself to
> act as a mediator because of your lack of response.

Let me disabuse you about those code reviews:

1. Your early submissions failed to build or upgrade cleanly.  I
usually insist that a junior developer submit binaries after doing
that to me a few times, but you were identified as a recruiting
prospect and were handled with kid gloves.

2. I let you ride for eight weeks hoping that you would notice the
dkms or configuration bugs.  You failed that test too because you
weren't using the software.  (ie: Dogfood principle.)

3. You left global search-and-replace artifacts at 661c4a4b, which
indicates unsafe coding habits.

4. Your rationale in fbc1bfef is demonstrably false, which means that
you invent bugs or fix things that aren't broken.  (In both dash and
bash, the logical && and || operators provide errexit protection.)

5. You added an unnecessary awk at e6fd8d0f and described it yourself
as "hellish".  I agree, that is low quality.  Never use a regex where
easily understandable code suffices.

6. The hostid issues pursuant to 2cc7293f would be termination
offenses in most software shops. You do not break customer systems.
Full stop; no discussion.

Aron was acting as middle-management here because you were scoring
nearly zero in code review, and I didn't want to embarrass you.

> Finally you just told us that you were not longer interested in working
> in this project inside Debian.

More accurately, I am no longer interested in covering for your
mistakes.  I just couldn't think of a simultaneously polite and honest
way to provide additional feedback or exit gracefully.

> I was offered to co-mentor the project because of my experience with the
> ZoL package inside Debian. If you hadn't tell us that you were not
> longer interested in packaging ZoL inside Debian, then you would have
> had the same chance to be a co-mentor of the project.

Your promotion from trainee to GSoC mentor was certainly rapid.

> And this is not a "product". This is Debian. If you don't know how open
> source communities work neither how Debian works, please go to learn it,
> and come back when you have learned the lesson. In the meanwhile I would
> thank you if you can stop spreading FUD.

Okay, sure, I need to learn how this works.  In your capacity as
project mentor and professional software developer, tell me more about
how Debian is not a product.

Darik Horn <dajhorn at vanadac.com>

More information about the Pkg-zfsonlinux-devel mailing list