[Pkg-zsh-devel] RFS: oh-my-zsh/0~20140211-1 [ITP]

[Axel Beckert]

Hi Jerome,

Jerome Charaoui wrote:
> I have recently packaged "oh-my-zsh" for Debian and am currently looking
> for a sponsor to review my work.

Hrm. While we're surely glad about add-ons to zsh in Debian, the
Debian Zsh Team so far has not so good experiences with oh-my-zsh --
there were quite some bug reports in Debian as well as upstream which
turned out to be oh-my-zsh bugs. Hence nobody in the Debian Zsh Team
uses oh-my-zsh -- and some even explicitly dislike it.

We surely won't hinder you to bring oh-my-zsh to Debian, but don't
expect much help from us either, especially with regards to bugs in
oh-my-zsh.

> http://mentors.debian.net/package/oh-my-zsh

I've reviewed the package. I'm glad, it doesn't enabled oh-my-zsh
globally. Please keep it that way. :-)

Most issues I found so far seem to be not packaging related:

"oh-my-zsh-config --install" does not check if I have already zsh as
login shell and calls chsh unconditionally

Likewise "oh-my-zsh-config --uninstall" wants to change my login shell
to bash despite it never was bash. It should e.g. honour if the user
had zsh or tcsh previously.

But "oh-my-zsh-config --uninstall" fails to do finish anyway:

➜  oh-my-zsh-0~20140211  oh-my-zsh-config --uninstall
This program will restore the configuration file stored in ~/.zshrc.pre-oh-my-zsh and change your login shell to bash. Proceed? [yN] y
Looking for original zsh config...
Found ~/.zshrc.pre-oh-my-zsh -- Restoring to ~/.zshrc
Found ~/.zshrc -- Renaming to ~/.zshrc.omz-uninstalled-20140306144659
/usr/share/oh-my-zsh/tools/uninstall.sh: 16: /usr/share/oh-my-zsh/tools/uninstall.sh: source: not found
Thanks for trying out Oh My Zsh. It's been uninstalled.
➜  oh-my-zsh-0~20140211

And if I exit the zsh started by "oh-my-zsh-config --install", it
throws the following error:

/usr/share/oh-my-zsh/tools/install.sh: 30: /usr/share/oh-my-zsh/tools/install.sh: source: not found

plugins/taskwarrior/_task is an outdated copy of what the package
taskwarrior installs into
/usr/share/zsh/functions/Completion/Unix/_task -- I'd remove that file
from the oh-my-zsh binary package (it's fine in the source package).

The reminder looks fine on a first glance.

Can you try to fix the above mentioned issues?

P.S.: Upstream doesn't seem to make releases. Do you have an idea how
you'll choose when to make a Debian package and when not? Are there
calm and hot phases in upstream's development?

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-zsh-devel/attachments/20140306/03a9afb9/attachment.sig>