[Pkg-zsh-devel] RFS: oh-my-zsh/0~20140211-1 [ITP]

[Jerome Charaoui]

Le 2014-03-06 09:15, Axel Beckert a écrit :
> Jerome Charaoui wrote:
>> I have recently packaged "oh-my-zsh" for Debian and am currently looking
>> for a sponsor to review my work.
> 
> Hrm. While we're surely glad about add-ons to zsh in Debian, the
> Debian Zsh Team so far has not so good experiences with oh-my-zsh --
> there were quite some bug reports in Debian as well as upstream which
> turned out to be oh-my-zsh bugs. Hence nobody in the Debian Zsh Team
> uses oh-my-zsh -- and some even explicitly dislike it.
>
> We surely won't hinder you to bring oh-my-zsh to Debian, but don't
> expect much help from us either, especially with regards to bugs in
> oh-my-zsh.

Am I to understand that oh-my-zsh was previously packaged for Debian,
and was removed? I could not find traces of that in BTS.

Is oh-my-zsh of good enough quality to be included in Debian? That's a
legitimate question! I'll admit that I'm fairly new to both packaging
and Zsh, so I may not the the best judge of that. It seemed good enough
to me after using it for a few weeks, and it does seem to have quite a
following on Github (which isn't an necessarily an accurate reflection
of quality, I'll admit).

Would to care to share some of those bugs you refer to? I may be
overlooking serious issues which might make me change my mind about
oh-my-zsh. Similarly, perhaps it has evolved positively since the team
last gave it a shot?


>> http://mentors.debian.net/package/oh-my-zsh
> 
> I've reviewed the package. I'm glad, it doesn't enabled oh-my-zsh
> globally. Please keep it that way. :-)

Agreed.


> Most issues I found so far seem to be not packaging related:
> 
> "oh-my-zsh-config --install" does not check if I have already zsh as
> login shell and calls chsh unconditionally
> 
> Likewise "oh-my-zsh-config --uninstall" wants to change my login shell
> to bash despite it never was bash. It should e.g. honour if the user
> had zsh or tcsh previously.

The install.sh and uninstall.sh scripts provided in oh-my-zsh are really
not pretty. I think my preffered solution would be to simply *not* ship
these scripts, and instead further document usage of oh-my-zsh in
README.Debian. Would this be acceptable?


> plugins/taskwarrior/_task is an outdated copy of what the package
> taskwarrior installs into
> /usr/share/zsh/functions/Completion/Unix/_task -- I'd remove that file
> from the oh-my-zsh binary package (it's fine in the source package).

Yep, thanks for the heads up.


> P.S.: Upstream doesn't seem to make releases. Do you have an idea how
> you'll choose when to make a Debian package and when not? Are there
> calm and hot phases in upstream's development?

I haven't followed it long enough to know how upstream dev rolls. I was
thinking of simply reviewing the commitlog every few weeks, and update
the package when it seems right (eg, when there are a bunch of bug
fixes). And of course when users request it via BTS.


Thanks for taking the time to review my package!

 -- Jerome

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 534 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-zsh-devel/attachments/20140306/4f0d35da/attachment.sig>