[Pkg-zsh-devel] Review request (was: Refreshing patches for z-sy-h 0.7.0)

[Axel Beckert]

Hi Daniel,

Daniel Shahaf wrote:
> https://salsa.debian.org/debian/zsh-syntax-highlighting/commit/e2fe8d5cbbc9eedeaf6893248aff642cb80b470b

Fair enough. There are other communities where the signatures are made
differently, too, especially CPAN, but IIRC the Perl Team just ignores
these (low-severity) warning instead of overriding them in several
thousand packages.

> https://salsa.debian.org/debian/zsh-syntax-highlighting/commit/04ea59a88debada12cbdbee4622ec1db4399b02e

This looks a bit ugly to me as it does not fit my idea of "as
installed"(*), but should be ok nevertheless.

(*) I wouldn't use rsync but would check for $AUTOPKGTEST_TMP and if
    present, run the tests directly on
    /usr/share/zsh-syntax-highlighting/. But this might need quite
    some code changes, like e.g. in ack's test suite:
    https://salsa.debian.org/perl-team/modules/packages/ack/blob/master/debian/patches/no-standalone-test-but-autopkgtests.patch
    It already has a variable based switch Debian doesn't need, so I'm
    misusing it for this purpose.

Easiest way to test if the setup is correct — in case you haven't
found out now: Running "autopkgtest -B ./ --- null" in the unpacked
source package given that the built package and all its dependencies
are installed. It's only a 90% check as it doesn't run the tests in a
clean chroot but your own system. But that suffices to check it the
autopkgtest setup generally works.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-zsh-devel/attachments/20190801/9594d3cd/attachment.sig>