[Pkg-zsh-devel] Question about your zsh 5.8-2ubuntu1 upload

[Steve Langasek]

Hi Axel,

On Thu, Feb 20, 2020 at 01:28:09AM +0100, Axel Beckert wrote:
> Hi Steve,

> a question about
> https://launchpadlibrarian.net/465739232/zsh_5.8-2_5.8-2ubuntu1.diff.gz:

> You've made two changes to debian/tests/control:

> * Add libpcre3 as dependency to run-testsuite, and
> * add a multiarch qualitfier to adequate.

> I can clearly see where the latter comes from, but it is not
> completely clear, why adding libpcre3 is related to cross-testing.

> The only guess I have, is, that the libpcre3 pulled in by the
> build-dependency on libpcre3-dev might have the wrong architecture
> (native). Can you confirm that suspicion.

> And if so, wouldn't it make more sense to add "needs-recommends" as
> restriction instead — since libpcre3 is in Recommends?

> Thanks in advance for an answer.

> Once it's clear to me, where the libpcre3 comes from, I intent to
> merge this change back into the Debian package.

I was going to file a bug about this (which I still can if you like), once I
had verified that the changes were sufficient to let the tests pass.  It
happens that they were not - for some reason that was not reproducible to me
locally.  So I've uploaded a subsequent change to mark zsh-doc Multi-Arch:
foreign, and that should be enough now to let the tests pass.

Regarding the libpcre3 change: the run-testsuite test includes upstream
tests that fail if libpcre3 is not available, but the test does not declare
a dependency on libpcre3.  You mention build-depends, but this test does not
declare a test dependency on the build-depends either.

I would have preferred to use Restriction: needs-recommends instead of
hard-coding a test dep on libpcre3 (which otherwise does not appear
hardcoded in the control files), but I found in the autopkgtest
documentation that the maintainers wish to consider this restriction
deprecated due to bug #896698 and referencing
<https://lists.debian.org/debian-ci/2018/06/msg00016.html>.

It's possible a test-dep on libpcre3-dev would be better, since this matches
debian/control.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-zsh-devel/attachments/20200219/7f92c853/attachment.sig>