[Pkg-zsh-devel] Question about your zsh 5.8-2ubuntu1 upload

[Axel Beckert]

Hi Steve,

Steve Langasek wrote:
> > a question about
> > https://launchpadlibrarian.net/465739232/zsh_5.8-2_5.8-2ubuntu1.diff.gz:
[...]
> > Once it's clear to me, where the libpcre3 comes from, I intent to
> > merge this change back into the Debian package.
> 
> I was going to file a bug about this (which I still can if you
> like),

Either that or telling me that 5.8-2ubuntu2 sufficed. :-)

I at least noticed that 5.8-2ubuntu2 is now in focal and no more in
focal-proposed. (Upstream will be happy. :-)

So I assume the tests passed now.

> once I had verified that the changes were sufficient to let the
> tests pass. It happens that they were not - for some reason that was
> not reproducible to me locally. So I've uploaded a subsequent change
> to mark zsh-doc Multi-Arch: foreign, and that should be enough now to
> let the tests pass.

Can I see those test results somewhere? Couldn't find them on
https://autopkgtest.ubuntu.com/packages/zsh/focal/amd64 — even 5.8-2
passed the tests there.

> Regarding the libpcre3 change: the run-testsuite test includes upstream
> tests that fail if libpcre3 is not available, but the test does not declare
> a dependency on libpcre3.  You mention build-depends, but this test does not
> declare a test dependency on the build-depends either.

Ah, I remembered it wrong: @ just includes the runtime dependencies,
not the build-dependencies.

> I would have preferred to use Restriction: needs-recommends instead of
> hard-coding a test dep on libpcre3 (which otherwise does not appear
> hardcoded in the control files), but I found in the autopkgtest
> documentation that the maintainers wish to consider this restriction
> deprecated due to bug #896698 and referencing
> <https://lists.debian.org/debian-ci/2018/06/msg00016.html>.

Indeed. Heard of that one too at the Debian Snow Camp.

> It's possible a test-dep on libpcre3-dev would be better, since this matches
> debian/control.

I'd probably use @builddep@ for now. Because this would pull in all
other Recommends (i.e. also libgdbm6 and libncursesw6) via their -dev
packages, too, I assume you wouldn't mind that deviation from your
ubuntu2 patch when merging it.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE