[Pkg-zsh-devel] zsh test suite failures under reprotest on Salsa

[Daniel Shahaf]

Daniel Shahaf wrote on Tue, 23 Jun 2020 12:18 +00:00:
> Axel Beckert wrote on Mon, 22 Jun 2020 04:24 +0200:
> > 7563 ../../Test/P01privileged.ztst: starting.
> > 7564 Selecting unprivileged UID:EUID pair automatically
> > 7565 Selecting unprivileged GID:EGID pair automatically
> > 7566 Using unprivileged UID 1, EUID 2, GID 1, EGID 2
> > 7567 Running test: PRIVILEGED automatically enabled when RUID != EUID
> > 7568 --- /tmp/zsh.ztst.14839/ztst.err 2020-06-21 13:45:57.442336033 -1200
> > 7569 +++ /tmp/zsh.ztst.14839/ztst.terr 2020-06-21 13:45:57.454336024 -1200
> > 7570 @@ -0,0 +1 @@
> > 7571 +ERROR: ld.so: object 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
> > 7572 Test ../../Test/P01privileged.ztst failed: error output differs from expected as shown above for:
> > 7573   re_zsh $ruid $ruid -1 -1 'echo $UID/$EUID $options[privileged]'
> > 7574   re_zsh $euid $euid -1 -1 'echo $UID/$EUID $options[privileged]'
> > 7575   re_zsh $ruid $euid -1 -1 'echo $UID/$EUID $options[privileged]'
> > 7576 Was testing: PRIVILEGED automatically enabled when RUID != EUID
> > 7577 ../../Test/P01privileged.ztst: test failed.
> > 
> > And for the second issue my gut feeling says this is either due to how
> > Salsa CI works or that Zsh should have detected this situation and not
> > run that test.
> 
> The test fails because the test harness was invoked with an invalid
> LD_PRELOAD value.  zsh's build system did not set up the libeatmydata.so
> preloading, so I don't see why it should have skipped the test.
> 
> Questions:
> 
> - What set up eatmydata?
> 
> - Why did the test fail with that error?
> 
> - Why did other *.ztst files _not_ fail?

I guess libeatmydata.so failed to be opened because the uid/gid had been
changed.  That'd answer the third question.

However, for the second question, why did libeatmydata.so fail to be
opened?  Normally eatmydata would be installed root:wheel 0555, in which
case it'd be usable even after changing the uid and gid.

Cheers,

Daniel