[Pkg-zsh-devel] zsh test suite failures under reprotest on Salsa

[Daniel Shahaf]

Axel Beckert wrote on Tue, 23 Jun 2020 17:25 +0200:
> Daniel Shahaf wrote:
> > The bug which the test tests for was fixed upstream in workers/45291.  
> 
> This seems to have been short before the 5.8 release and is hence
> included, right?

That change is not included in the 5.8 release because it was pushed to
a different branch than 5.8 was tagged from.  (The use of branches
before the 5.8 release is described in workers/45441, though a bit
briefly.)  It will, however, be included in 5.9.

> > > 7576 Was testing: PRIVILEGED automatically enabled when RUID != EUID
> > > 7577 ../../Test/P01privileged.ztst: test failed.
> > > 
> > > And for the second issue my gut feeling says this is either due to how
> > > Salsa CI works or that Zsh should have detected this situation and not
> > > run that test.  
> > 
> > The test fails because the test harness was invoked with an invalid
> > LD_PRELOAD value.  zsh's build system did not set up the libeatmydata.so
> > preloading, so I don't see why it should have skipped the test.
> > 
> > Questions:
> > 
> > - What set up eatmydata?  
> 
> Likely the container in which the test was run, i.e. either Salsa's CI
> itself or the pipeline defined by the Salsa CI Team.
> 

*nod*

> > - Why did the test fail with that error?  
> 
> Good question.
> 
> > - Why did other *.ztst files _not_ fail?  
> 
> Even better question!
> 

I wonder if perhaps eatmydata was installed in the
user-that-runs-the-build's home directory.

> Daniel Shahaf wrote:
> > > > 6585 Was testing: unreadable directories can be globbed (users/24619, users/24626)
> > > > 6586 ../../Test/D02glob.ztst: test failed.  
> > > 
> > > (that's what the output says, though it's not immediately clear),  
> > 
> > Patch sent upstream: workers/46102.  
> 
> Hmmm, I don't get that patch. But maybe because understanding the
> output was not my issue. :-)

The point of that patch is to make line 6586 say "Test XPassed" rather
than "Test failed", because the latter normally connotes that the test
had been expected to pass.

Cheers,

Daniel