[Popcon-developers] Bug#331438: wrong usage of "su" in /etc/cron.weekly/popularity-contest

[Christian Kujau]

Package: popularity-contest
Version: 1.31
Severity: normal
Tags: patch


invoking /etc/cron.weekly/popularity-contest fails with:
"sh: - : invalid option". looking into the script, line 34 tries to "su"
to nobody and executes /usr/sbin/popularity-contest. the following patch
should speak for itself:

--- /etc/cron.weekly/popularity-contest.orig	2005-10-03 15:30:04.821775208 +0200
+++ /etc/cron.weekly/popularity-contest	2005-10-03 15:33:25.158908688 +0200
@@ -31,7 +31,7 @@
 run_popcon()
 {
 	# Set HOME to avoid bug #212013.
-	HOME=/tmp su nobody -pc "sh -c /usr/sbin/popularity-contest"
+	HOME=/tmp su -pc "sh -c /usr/sbin/popularity-contest" nobody
 }
 
 do_sendmail()


thank you for your time,
Christian.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13.2
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages popularity-contest depends on:
ii  debconf [debconf-2.0]        1.4.58      Debian configuration management sy
ii  dpkg                         1.13.11.0.1 package maintenance system for Deb

Versions of packages popularity-contest recommends:
ii  cron                          3.0pl1-91  management of regular background p
ii  exim4                         4.53-1     metapackage to ease exim MTA (v4) 
ii  exim4-daemon-heavy [mail-tran 4.53-1     exim MTA (v4) daemon with extended
pn  mime-construct                <none>     (no description available)

-- debconf information:
  popularity-contest/hostid-failed:
* popularity-contest/participate: true
* popularity-contest/use-http: true