[Popcon-developers] add -s /bin/sh in case nobody has no shell.

Bill Allombert Bill.Allombert at math.u-bordeaux1.fr
Wed Aug 15 16:45:14 UTC 2007


Hello Petter,

I propose the following patch:
 - add -s /bin/sh in case nobody has no shell. Closes: #429405, #431867.

Cheers,
-- 
Bill. <ballombe at debian.org>

Imagine a large red swirl here. 


Index: debian/changelog
===================================================================
RCS file: /cvsroot/popcon/popularity-contest/debian/changelog,v
retrieving revision 1.371
diff -u -r1.371 changelog
--- debian/changelog	15 Aug 2007 15:20:58 -0000	1.371
+++ debian/changelog	15 Aug 2007 16:36:26 -0000
@@ -9,7 +9,9 @@
   * popularity-contest used files regexp:
     - add support for php scripts
     - Add missing $ after .pm. Closes #431535, Thanks Gerfried Fuchs.
-  * cron.weekly: remove spurious 'sh -c' in run_popcon()
+  * cron.weekly, function run_popcon(): 
+    - remove spurious 'sh -c'
+    - add -s /bin/sh in case nobody has no shell. Closes: #429405, #431867.
 
  -- Bill Allombert <ballombe at debian.org>  Tue, 19 Jun 2007 17:04:48 +0200
 
Index: debian/cron.weekly
===================================================================
RCS file: /cvsroot/popcon/popularity-contest/debian/cron.weekly,v
retrieving revision 1.20
diff -u -r1.20 cron.weekly
--- debian/cron.weekly	19 Jun 2007 15:06:21 -0000	1.20
+++ debian/cron.weekly	15 Aug 2007 16:36:26 -0000
@@ -30,7 +30,7 @@
 
 run_popcon()
 {
-	su -c "/usr/sbin/popularity-contest" nobody
+	su -s /bin/sh -c "/usr/sbin/popularity-contest" nobody
 }
 
 do_sendmail()



More information about the Popcon-developers mailing list