[Popcon-developers] Bug#431535: popularity-contest: match for vote files lacks a $

Gerfried Fuchs rhonda at debian.at
Mon Jul 2 13:42:27 UTC 2007


Package: popularity-contest
Version: 1.42
Severity: minor

        Hi!

 I've found this match in the script for grepping for files to check for
a vote:

   m{/bin/|/sbin/|^/usr/games/|\.[ah]$|\.pm|^/boot/System\.map-} or next;

 You can see that there is a $ after \.[ah] but none after \.pm.  This
might be able to generate false-positives (left aside all the problems
that the vote system has anyway: checks only the first match, not all of
them, has problems with read-only mounted filesystems and noatime flags,
...).

 Quite easy to fix this minor problem, which e.g. currently matches
/usr/share/doc/HOWTO/en-html/Lego/rcx.pm.html

 So long,
Rhonda




More information about the Popcon-developers mailing list