[Popcon-developers] Bug#431535: popularity-contest: match for vote files lacks a $

[Bill Allombert]

On Mon, Jul 02, 2007 at 03:42:27PM +0200, Gerfried Fuchs wrote:
> Package: popularity-contest
> Version: 1.42
> Severity: minor
> 
>         Hi!
> 
>  I've found this match in the script for grepping for files to check for
> a vote:
> 
>    m{/bin/|/sbin/|^/usr/games/|\.[ah]$|\.pm|^/boot/System\.map-} or next;
> 
>  You can see that there is a $ after \.[ah] but none after \.pm.  This
> might be able to generate false-positives (left aside all the problems
> that the vote system has anyway: checks only the first match, not all of
> them, has problems with read-only mounted filesystems and noatime flags,
> ...).

Hello Gerfried,

I do not think popularity-contest only check the first match. If this is
the case I would like more information on the problem.

>  Quite easy to fix this minor problem, which e.g. currently matches
> /usr/share/doc/HOWTO/en-html/Lego/rcx.pm.html

Sure we will fix that, thanks for the report!

Cheers,
-- 
Bill. <ballombe at debian.org>

Imagine a large red swirl here.