[Python-apps-team] Bug#928885: FTBFS with librsync 2

[Andrey Rahmatullin]

Package: src:rdiff-backup
Version: 1.2.8-7
Severity: normal
Tags: upstream

We plan upgrading librsync to 2.0.2 after the buster release, see #776246. This
version is not API-compatible with 0.9.7 but it seems the only package that
breaks is rdiff-backup:

x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fdebug-prefix-
map=/build/python2.7-IbFBHb/python2.7-2.7.16=. -fstack-protector-strong
-Wformat -Werror=format-security -fPIC -I/usr/include/python2.7 -c
_librsyncmodule.c -o build/temp.linux-x86_64-2.7/_librsyncmodule.o
_librsyncmodule.c: In function ‘_librsync_new_sigmaker’:
_librsyncmodule.c:63:17: error: ‘RS_DEFAULT_STRONG_LEN’ undeclared (first use
in this function); did you mean ‘RS_DEFAULT_BLOCK_LEN’?
         (size_t)RS_DEFAULT_STRONG_LEN);
                 ^~~~~~~~~~~~~~~~~~~~~
                 RS_DEFAULT_BLOCK_LEN
_librsyncmodule.c:63:17: note: each undeclared identifier is reported only once
for each function it appears in
_librsyncmodule.c:62:17: error: too few arguments to function ‘rs_sig_begin’
   sm->sig_job = rs_sig_begin((size_t)blocklen,
                 ^~~~~~~~~~~~
In file included from _librsyncmodule.c:25:
/usr/include/librsync.h:397:11: note: declared here
 rs_job_t *rs_sig_begin(size_t new_block_len, size_t strong_sum_len,
           ^~~~~~~~~~~~

Please do something with this. New librsync is available in experimental. This
bug report will be upgraded to RC once the freeze ends.



-- System Information:
Debian Release: 10.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.0.0-trunk-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled