[Python-modules-team] Bug#753578: Packaging of python-requests breaks code relying on urllib3

[Markus Unterwaditzer]

Hi Daniele,

On Thu, Jul 03, 2014 at 12:33:42PM +0200, Daniele Tricoli wrote:
> Hello Markus,
> thanks for your report!
> 
> On Thursday 03 July 2014 11:27:34 Markus Unterwaditzer wrote:
> > The patch for extracting urllib3 out of requests does not supply a stub for
> > ``requests.packages.urllib3``, which breaks other code explicitly importing
> > from that location.
> 
> I will make this import fallback to urllib3 system package to not break other 
> code.
> 
> Dimitri John Ledkov already explained[¹] why in Debian we don't ship 
> convenience copy of code[²].

To clarify, i fully understand why you do that.

> 
> Only as curiosity: in vdirsyncer you choosed to use the convenience copy of 
> urllib3 only to not make your users download urllib3, right?

That isn't a choice made by me, i am just depending on requests-toolbelt, which
refers the convenience copy. My own code doesn't. Neither vdirsyncer nor
requests-toolbelt are in the Debian repos.

requests-toolbelt explicitly depending on urllib3 and using that package would
add more fuel to the fire, i believe, as requests-toolbelt now would use a
different version of urllib3 than requests does, at least outside of
Debian-land.

> 
> > The bundled version of urllib3 is part of requests' API:
> > http://www.python-requests.org/en/latest/user/advanced/#example-specific-ssl
> > -version
> 
> I think this is unfortunate but this is not the place where to discuss: I will
> ask upstream to not suggest to use convenience copies in documentation. :)
> 
> If you look at
> 
> https://github.com/kennethreitz/requests/blob/master/requests/packages/README.rst
> 
> you will see that requests doesn't modify anymore the embedded copy of urllib3 
> (in past the embedded copy was modified indeed I could not use it only for 
> requests 1.0.1-1 [³]).
> 
> > See https://github.com/untitaker/vdirsyncer/issues/82 for the original
> > issue.
> 
> I will link my reply also there.
> 
> Cheers,
> 
> [¹] https://github.com/untitaker/vdirsyncer/issues/82#issuecomment-47888471
> [²] https://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles
> [³] https://packages.qa.debian.org/r/requests/news/20130203T213245Z.html
> 
> -- 
>  Daniele Tricoli 'Eriol'
>  http://mornie.org
> 
> --
> To unsubscribe, send mail to 753578-unsubscribe at bugs.debian.org.