[Python-modules-team] Bug#753578: Packaging of python-requests breaks code relying on urllib3

[Daniele Tricoli]

Hello Markus,

On Thursday 03 July 2014 12:47:00 Markus Unterwaditzer wrote:
> To clarify, i fully understand why you do that.

Sorry if I appeared to be rude: it was not my intention! I'm not a native 
speaker and I was in a hurry.

> That isn't a choice made by me, i am just depending on requests-toolbelt,
> which refers the convenience copy. My own code doesn't. Neither vdirsyncer
> nor requests-toolbelt are in the Debian repos.

Yes, I see. I looked in a hurry to vdirsyncer's issue and I based my reasoning 
in this report. Anyway my was simply curiosity: for my Python projects I 
prefer not to embedd external libraries but a listen a different point of view 
is always important IMO.

I just discovered vdirsyncer thanks to your bug report and I find it useful, 
so maybe next time I'll ping you to tell that I'm going to package it for 
Debian. :)

> requests-toolbelt explicitly depending on urllib3 and using that package
> would add more fuel to the fire, i believe, as requests-toolbelt now would
> use a different version of urllib3 than requests does, at least outside of
> Debian-land.

I have added a stub entry point for requests.packages.urllib3: it use urllib3 
system packages to comply with our policy.

About your fears, on the diverging versions used in Debian I must confess that 
I did feel the same when I removed the embedded copy. It was 20 Jan 2013 and 
this bug report is the first related to a packaging choice. urllib3, up to 
now, was stable enough to not require the use of the convenience copy. I don't 
think circumstances will change in future, but, in case, I will change the 
packaging. I'm also a user of requests, so I want it in the best shape in 
Debian! ;)

My workflow is to run always the testsuite: for requests I not enabled testing 
at built time due to this

    https://github.com/kennethreitz/requests/issues/1166

A package to stay in main archive have to build fine without internet 
connection, but when it will be closed I will enable both tests at build time 
and Debian CI[¹].

Thanks for this report, it was really appreciated!

[¹] http://dep.debian.net/deps/dep8/

-- 
 Daniele Tricoli 'Eriol'
 http://mornie.org