[Python-modules-team] Bug#878108: python3-guzzle-sphinx-theme: links jquery.js to minified version, causing dh_sphinxdoc to fail

[Sven Hartge]

Package: python3-guzzle-sphinx-theme
Version: 0.7.11-1
Severity: normal

Hi!

During compilation (in a clean pbuilder chroot) of the new borgbackup
1.1.0 packages based on the current Debian packages I stumbled upon the
following problem:

At buildtime dh_sphinxdoc fails like this:

make[1]: Leaving directory '/build/borgbackup-1.1.0'
   dh_sphinxdoc -O--buildsystem=pybuild
dh_sphinxdoc: error: unknown JavaScript code: debian/borgbackup-doc/usr/share/doc/borgbackup-doc/html/_static/jquery.js
debian/rules:44: recipe for target 'binary' failed

The reason is python3-guzzle-sphinx-theme links its jquery.js to the
minified version:

lrwxrwxrwx 1 root root 55 Jun 25 01:28 /usr/lib/python3/dist-packages/guzzle_sphinx_theme/guzzle_sphinx_theme/static/jquery.js -> ../../../../../../share/javascript/jquery/jquery.min.js

Because of this, dh_sphinxdoc fails to compare the copied jquery.js with the unminified version in
/usr/share/javascript/jquery/jquery.js and aborts.

Proposed solution:

diff -Nru guzzle-sphinx-theme-0.7.11/debian/links guzzle-sphinx-theme-0.7.11/debian/links
--- guzzle-sphinx-theme-0.7.11/debian/links     2017-06-25 01:28:28.000000000 +0200
+++ guzzle-sphinx-theme-0.7.11/debian/links     2017-10-09 22:42:03.000000000 +0200
@@ -10,4 +10,5 @@
 usr/share/javascript/bootstrap/fonts/glyphicons-halflings-regular.woff2        usr/lib/python3/dist-packages/guzzle_sphinx_theme/guzzle_sphinx_theme/static/fonts/glyphicons-halflings-regular.woff2
 usr/share/javascript/bootstrap/js/bootstrap.js                         usr/lib/python3/dist-packages/guzzle_sphinx_theme/guzzle_sphinx_theme/static/js/bootstrap.js
 usr/share/javascript/bootstrap/js/bootstrap.min.js                     usr/lib/python3/dist-packages/guzzle_sphinx_theme/guzzle_sphinx_theme/static/js/bootstrap.min.js
-usr/share/javascript/jquery/jquery.min.js                              usr/lib/python3/dist-packages/guzzle_sphinx_theme/guzzle_sphinx_theme/static/jquery.js
+usr/share/javascript/jquery/jquery.min.js                              usr/lib/python3/dist-packages/guzzle_sphinx_theme/guzzle_sphinx_theme/static/jquery.min.js
+usr/share/javascript/jquery/jquery.js                                  usr/lib/python3/dist-packages/guzzle_sphinx_theme/guzzle_sphinx_theme/static/jquery.js

This is essentially the same linkage as already done for bootstrap.js and bootstrap.min.js.

Grüße,
Sven.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable'), (400, 'testing'), (100, 'experimental'), (1, 'experimental-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-1-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages python3-guzzle-sphinx-theme depends on:
ii  dpkg              1.18.24
ii  fonts-liberation  1:1.07.4-4
ii  libjs-bootstrap   3.3.7+dfsg-2
ii  libjs-jquery      3.2.1-1
ii  python3           3.5.3-3
ii  python3-sphinx    1.6.4-2

python3-guzzle-sphinx-theme recommends no packages.

python3-guzzle-sphinx-theme suggests no packages.

-- no debconf information