[Python-modules-team] Comments regarding python-tornado4_4.5.3-2_amd64.changes

[eamanu15]

Hi!

I think now it's ok.

https://salsa.debian.org/python-team/modules/python-tornado/commit/70526d2ad0022925b3f23f1b71e50928df1051f0

Please, review it.

Regards

El jue., 27 de dic. de 2018 a la(s) 09:43, eamanu15 (
emmanuelarias30 at gmail.com) escribió:

> Hi Lamby!
>
> El jue., 27 de dic. de 2018 a la(s) 05:30, Chris Lamb (lamby at debian.org)
> escribió:
>
>> Hi eamanu15,
>>
>> > I push the patch to salsa.
>> >
>> > Please, review it.
>>
>> Assuming you mean:
>>
>>
>> https://salsa.debian.org/python-team/modules/python-tornado/commit/397def589597dd2deed12289f4858ec0a875e35a
>>
>> ... I would probably prefer to see something based on:
>>
>>   https://reproducible-builds.org/docs/source-date-epoch/
>>
>> … as that is more likely to be accepted upstream.
>>
>
> Thanks, so I will work with source date epoch
>
>>
>> (In addition, the above commit I link to above contains a bunch of
>> changes unrelated to the commit [message] itself. These are better
>> done in other commits to make review easier/faster, especially when
>> asking others to take a look.)
>>
>
> Ok :-)
>
>>
>>
>> Regards,
>>
>> --
>>       ,''`.
>>      : :'  :     Chris Lamb
>>      `. `'`      lamby at debian.org / chris-lamb.co.uk
>>        `-
>>
>
>
> --
> Arias Emmanuel
> http://eamanu.com
> Github/Gitlab; @eamanu
> Debian: @eamanu-guest
>


-- 
Arias Emmanuel
http://eamanu.com
Github/Gitlab; @eamanu
Debian: @eamanu-guest
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/python-modules-team/attachments/20181227/0f3a32b9/attachment.html>