[Qa-debsources] [PATCH] Add test for index news, bug #783461

Matthieu Caneill matt at brokenwa.re
Mon Mar 21 23:18:37 UTC 2016


Hi!

On Mon, Mar 21, 2016 at 06:50:22AM +0000, Aaron Delaney wrote:
> Link for the lazy: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=783461

(very much appreciated ;) )

> This is my first time committing a patch (on any software that isn't on
> Github)
> so I might do stuff wrong. That being said I won't take criticism
> personally.

It seems you didn't use git format patch to send it to us. A simple
diff would also be fine, but even extracting it from your email, I
can't apply it because of the line below (but there are others,
probably due to your email client trimming long lines).
Could you fix it please?

> +        # Create temporary news files to test, they return the data
> written to
> +        # the file, or the data that was already there if they already
> existed

-> here, newlines break the patch.

Thanks in advance,
--
Matthieu



More information about the Qa-debsources mailing list