[Qa-debsources] [PATCH] Add test for index news, bug #783461

[Matthieu Caneill]

Hey,

On Tue, Mar 22, 2016 at 07:47:25AM +0000, Aaron Delaney wrote:
> Good review, I didn't pick up on the locals directory not existing and
> your right about the bad docstring on the function.
> 
> I decided to ditch the function because it seemed more appropriate
> to just keep everything in the one function now that it was handling
> all news tests.

Perfect.

> I've attached the file again, is that unnecessary or is it helpful to
> you?

Yes, I prefer to receive patches as attachments (so I can quicky
apply them to my local debsources repo).

> Let me know what you think,

Looks perfect, I'll merge it. I've added a remark below for the sake
of completion.

> +    def test_news(self):
> +        # news_routes = { news_filename: associated_route }
> +        news_routes = {
> +            'sources_news.html':    '/',
> +            'copyright_news.html': '/copyright/',
> +            'patches_news.html':   '/patches/'
> +        }

This could have been fetched from
self.app.whatever_function_lists_registered_blueprints(), to
automatically support future blueprints. But this way is just fine
IMHO and at the rate we add blueprints.

Thanks for your implication!
Cheers,
--
Matthieu