[Qa-jenkins-dev] remaining review of 180192b74..85c8b0211

[Mattia Rizzolo]

On Thu, Apr 12, 2018 at 10:17:26PM +0000, Holger Levsen wrote:
> df10b0d26b: can we afford to keep the old worker logs a day longer?

yes, I only noticed an average increase in the used space on the
relevant partition of ~10%, i.e. 

> c276d112b: has one non-comment change...

Are you referring to the -Djava.net.preferIPv4Stack=true arg?  As the
commit message says, that's coming from the upstream package; also
looking at the relevant java doc it seemed sane to me.

> 3db1646f9: oh, you reimplemented fcopy :) (though i do like
> ./hosts/common/)

I haven't moved to common/ all the files that could be moved.  Before
doing so every file need to be checked for whether some host has some
modification, which makes doing it kind of a long process...

> 0fb4a33c1: i dont think that file was accidently commited...?!?!

That file has nothing to do with the commit that added it… I believe it
was a previous iteration of bin/cgi-bin/nph-logwatch or something like
that.
Would you happen to remember what it was for?  I couldn't find any
reference to it on the rest of the code nor elsewhere.

> 12b21850f: AFAICS the commit message is the only documentation of this,
> shouldnt this also be noted in TODO for future reference/cleanup?

Mhh yeah…
I also haven't mentioned that I applied such workaround in the relevant
bug report.
Will try to remember to do it during the weekend.

> we could have a check / simple grep for git repos not yet migrated to
> salsa...

What are you referring to?

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/qa-jenkins-dev/attachments/20180413/3ee9ee84/attachment.sig>