[R-pkg-team] r-cran-survminer_0.4.6-1_amd64.changes REJECTED

Andreas Tille andreas at an3as.eu
Thu Apr 9 14:09:19 BST 2020


Hi Scott,

thanks again for your thoroug and speedy checking.

On Wed, Apr 08, 2020 at 08:10:11PM +0000, Scott Kitterman wrote:
> 
> There are two major issues that I noticed before I gave up.
> 
> 1.  inst/doc/Specifiying_weights_in_log-rank_comparisons.html is chock full of
> sourceless Javascript, which it not allowed in Main (need preferred form of
> modification).  That would be enough to require a reject.

Arrrgh.  That is removed.  I simply missed that.
 
> 2.  vignettes/README.md says `ggsci.css` was borrowed from [`ggsci`](https://
> github.com/road2stat/ggsci/tree/master/vignettes) package.  This package is
> GPL-2 and ggsci is GPL-3 and has a different copyright.  Please have a look
> and see if the GPL-2 and GPL-3 code interact in a way that would cause a
> license incompatiblity problem (GPL-2 and GPL-3 are incompatible).  If that's
> not a problem, then the license and copyright information for ggsci.css need
> to be in debian/copyright.

This css file is just used to create the documentation.  Its not used
when executing the code.  In principle any other css could be used to
create the docs - than these would look just different than the template
given by a related package.  Since this does not look like any conflict
regarding an interaction of differently licensed code I simply added
another paragraph to d/copyright and re-uploaded.

Thanks again

      Andreas.

-- 
http://fam-tille.de



More information about the R-pkg-team mailing list