[R-pkg-team] Bug#949658: Different tests for r-cran-recipes - "wrong" test prevents migration of r-cran-testthat

[Andreas Tille]

Hi,

when looking at the CI page for r-cran-recipes which is linked from tracker.d.o[1]
all tests are passing.  The latest log[2] says:

...
Attaching package: 'recipes'

The following object is masked from 'package:stats':

    step

> 
> if (requireNamespace("xml2")) {
+   test_check("recipes", reporter = MultiReporter$new(reporters = list(JunitReporter$new(file = "test-results.xml"), CheckReporter$new())))
+ } else {
+   test_check("recipes")
+ }
Loading required namespace: xml2
== testthat results  ===========================================================
[ OK: 1434 | SKIPPED: 8 | WARNINGS: 0 | FAILED: 0 ]
> 
autopkgtest [19:42:48]: test run-unit-test: -----------------------]
autopkgtest [19:42:48]: test run-unit-test:  - - - - - - - - - - results - - - - - - - - - -
run-unit-test        PASS
autopkgtest [19:42:48]: @@@@@@@@@@@@@@@@@@@@ summary


However, if I look at the tracker page of r-cran-testthat[3] there is
a blocker for testing migration:

  autopkgtest for r-cran-recipes/0.1.9+dfsg-1: amd64: Regression ♻ , arm64: Regression ♻ 

It links to a log[4] that seems to run on testing which says:

...
Attaching package: 'recipes'

The following object is masked from 'package:stats':

    step

> 
> if (requireNamespace("xml2")) {
+   test_check("recipes", reporter = MultiReporter$new(reporters = list(JunitReporter$new(file = "test-results.xml"), CheckReporter$new())))
+ } else {
+   test_check("recipes")
+ }
Loading required namespace: xml2
3 packages are needed for this model and are not installed. (RSpectra, igraph, RANN). Start a clean R session then run: install.packages(c("RSpectra", "igraph", "RANN"))-- 1. Error: quasiquotation (@test_slice.R#40)  --------------------------------
`call` must be a call

== testthat results  ===========================================================
[ OK: 1428 | SKIPPED: 9 | WARNINGS: 0 | FAILED: 1 ]
1. Error: quasiquotation (@test_slice.R#40) 

Error: testthat unit tests failed
Execution halted
autopkgtest [13:11:23]: test run-unit-test: -----------------------]
autopkgtest [13:11:23]: test run-unit-test:  - - - - - - - - - - results - - - - - - - - - -
run-unit-test        FAIL non-zero exit status 1
autopkgtest [13:11:23]: @@@@@@@@@@@@@@@@@@@@ summary
run-unit-test        FAIL non-zero exit status 1



I guess one difference [install.packages(c("RSpectra", "igraph", "RANN"))]
is missing above since I just uploaded a new version including these
Build-Depends.  But there is this remaining

  1. Error: quasiquotation (@test_slice.R#40)
  `call` must be a call

and I have no idea how to fix this.  May be there is some unspecified
versioned Build-Depends or something like this.

Is there any chance to let r-cran-testthat and r-cran-recipes (as well
as all its rdepends) migrate easily?  Otherwise the only chance I see is
to deactivate the according test, let packages migrate and activate it
once this had happened.

Any better advise would be perfectly welcome.

Kind regards

         Andreas.


[1] https://ci.debian.net/packages/r/r-cran-recipes/unstable/amd64/
[2] https://ci.debian.net/data/autopkgtest/unstable/amd64/r/r-cran-recipes/4080660/log.gz
[3] https://tracker.debian.org/pkg/r-cran-testthat
[4] https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-recipes/4072773/log.gz

-- 
http://fam-tille.de