[R-pkg-team] Bug#1038405: Bug#1037439: r-cran-rstan/armhf FTBFS with r-cran-bh 1.74

[Dirk Eddelbuettel]

On 31 July 2023 at 23:13, Adrian Bunk wrote:
| On Mon, Jun 19, 2023 at 04:37:22PM +0300, Adrian Bunk wrote:
| > On Tue, Jun 13, 2023 at 03:30:18PM -0500, Dirk Eddelbuettel wrote:
| > > 
| > > On 13 June 2023 at 13:15, Steve Langasek wrote:
| > > | Control: reassign -1 r-cran-rstan r-cran-bh
| > > | Control: found -1 r-cran-rstan/2.21.8-1
| > > | 
| > > | Unfortunately, at least in Ubuntu it appears the r-cran-rstan build still
| > > | exhausts the 32-bit memory space even with boost 1.81.
| > > | 
| > > |   https://launchpad.net/ubuntu/+source/r-cran-rstan/2.21.8-1/+build/26010118
| > > 
| > > :-/
| > > 
| > > Not sure that it is fair to point at BH / Boost though.  Anyway.
| > > 
| > > CRAN no longer checks / compiles 32 bit so upstream may not care, but they
| > > are a good team (if busy).  You could ping Ben, he is at
| > >    Benjamin K Goodrich <benjamin.goodrich at columbia.edu>
| > >...
| > 
| > The patch below to r-base fixes the build of r-cran-rstan/i386 for me.
| > 
| > This will reduce debug info in the R ecosystem on 32bit to what is 
| > required for backtraces, but I assume realistically R on 32bit is
| > anyway only sparsely used these days.
| > 
| > > Dirk
| > 
| > cu
| > Adrian
| > 
| > --- debian/rules.old	2023-06-18 19:45:14.437261923 +0000
| > +++ debian/rules	2023-06-18 19:51:30.097179612 +0000
| > @@ -90,6 +90,11 @@
| >  export DEB_CFLAGS_MAINT_APPEND = -ffloat-store
| >  endif
| >  
| > +## fewer debug info on 32bit to workaround 2-4 GB address space limitation
| > +ifeq ($(DEB_HOST_ARCH_BITS), 32)
| > +export DEB_CFLAGS_MAINT_APPEND += -g1
| > +endif
| > +
| >...
| 
| These two entries ended up in the opposite order in the upload, and the 
| -ffloat-store one did not have a += making the -g1 change a nop on i386.
| 
| Please apply also the patch below.
| 
| cu
| Adrian
| 
| --- debian/rules.old	2023-07-26 07:56:06.872438302 +0000
| +++ debian/rules	2023-07-26 07:56:27.340457680 +0000
| @@ -92,7 +92,7 @@
|  
|  ## Adrian Bunk 20 Jan 2023  workaround excess precision of x87
|  ifneq (,$(filter $(DEB_HOST_ARCH), i386))
| -export DEB_CFLAGS_MAINT_APPEND = -ffloat-store
| +export DEB_CFLAGS_MAINT_APPEND += -ffloat-store
|  endif
|  
|  ## edd 31 Mar 2014

Flim!  Thanks for catching that, that's what I get for manually patching.

Will fix now.

Dirk

-- 
dirk.eddelbuettel.com | @eddelbuettel | edd at debian.org