[R-pkg-team] Bug#1028130: r-cran-hunspell: please don't use internal en_US and en_GB dictionaries

[Andreas Tille]

Hi Rene,

Am Mon, Jan 09, 2023 at 09:40:17PM +0100 schrieb Rene Engelhard:
> 
> Of course that now happens if you build against sid.
> 
> The private headers now are for 1.7.2 - which as of now is in experimental
> and thus you need to build against 1.7.2 (and probably have a updated
> runtime dependency.)

Ah, sorry for missing this.
 
> Which is what my patch does in addition to the headers only. You just
> applied the header change in https://salsa.debian.org/r-pkg-team/r-cran-hunspell/-/commit/ae8796cc2e2b72372b55cf40ce35a15bf00ae2d8,
> neither the build-dependency nor the runtime dependency. Do that and build
> against hunspell 1.7.2 and it will build.
> 
> 
> The problem per se is that you copy private stuff over.

I'm aware that this is not a nice solution - I considered a bit better
then keeping a full code copy of hunspell which is shipped by upstream.
On the other hand this would saved us some work now.
 
After merging your MR the package builds.  However, I get two failures
when running its test suite:


══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-encodings.R:16'): Dictionaries are found ─────────────────────
hunspell_info("en_US")$wordchars not equal to "’".
1/1 mismatches
x[1]: "0123456789’"
y[1]: "’"
── Failure ('test-encodings.R:17'): Dictionaries are found ─────────────────────
hunspell_info("en_GB")$wordchars not equal to "’".
1/1 mismatches
x[1]: "0123456789’"
y[1]: "’"

[ FAIL 2 | WARN 0 | SKIP 0 | PASS 126 ]
Error: Test failures

Kind regards

      Andreas.

-- 
http://fam-tille.de