[R-pkg-team] Bug#1028124: Bug#1028130: r-cran-hunspell: please don't use internal en_US and en_GB dictionaries

[Rene Engelhard]

Hi,

Am 10. Januar 2023 08:01:31 MEZ schrieb Andreas Tille <andreas at an3as.eu>:

>> The problem per se is that you copy private stuff over.
>
>I'm aware that this is not a nice solution - I considered a bit better
>then keeping a full code copy of hunspell which is shipped by upstream.

Oh my... Yeah, it probably is. If you filed a bug with a wish for a libhunspell-private-dev or somesuch (as e.g. poppler or Qt do) I am not sure I'd have done that but that'd probably be the cleanest solution. (Though given the waiting time in NEW for simple binary package additions I'd now not like to have to do it..
)

>On the other hand this would saved us some work now.

Maybe, yes, but...

>After merging your MR the package builds.  However, I get two failures
>when running its test suite:
>
>
>══ Failed tests ════════════════════════════════════════════════════════════════
>── Failure ('test-encodings.R:16'): Dictionaries are found ─────────────────────
>hunspell_info("en_US")$wordchars not equal to "’".
>1/1 mismatches
>x[1]: "0123456789’"
>y[1]: "’"

Groan. Looks like it needs some specific stuff in the dictionaries it has which are now used from the system. I don't think it should not do that, can't the tests be adapted?

Regards

René 
-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.