Bug#1122389: golang-mvdan-editorconfig: please make the build reproducible

[Chris Lamb]

Source: golang-mvdan-editorconfig
Version: 0.2.0+git20240816.eab549b-2
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: nocheck
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
golang-mvdan-editorconfig could not be built reproducibly.

This is because the call to remove the _sample directory was
effectively in the wrong debian/rules target. Whilst it was in the
execute_after_dh_auto_test target, this target is not called if the
tests are skipped — meaning that if the tests aren't run, then the
binary package will contain the contents of _sample. Specifically
this file:

  /usr/share/gocode/src/mvdan.cc/editorconfig/_sample/subdir/code.go

The other deletions (of core-test and CMakeLists.txt) are in the
'right' target, but the attached patch simply renames the target:
it could be split into two so the difference is more explicit, but
your call.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2025-12-10 11:31:12.091537585 -0800
--- b/debian/rules	2025-12-10 12:02:46.865955693 -0800
@@ -12,5 +12,5 @@
 	cp CMakeLists.txt $(BUILDDIR)
 	cp -r _sample/ $(BUILDDIR)
 
-execute_after_dh_auto_test:
+execute_before_dh_auto_install:
 	find $(BUILDDIR) -name core-test -o -name CMakeLists.txt -o -name _sample | xargs rm -rf