Bug#1122390: golang-github-digitorus-timestamp: please make the build reproducible

[Chris Lamb]

Source: golang-github-digitorus-timestamp
Version: 0.0~git20231217.220c5c2-2
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: nocheck
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
golang-github-digitorus-timestamp could not be built reproducibly.

This is because the call to remove some tests were in the wrong
debian/rules target. Whilst it was in override_dh_auto_test, this target
is not called if the tests are skipped — meaning that if the tests
aren't run, then the package contains those files.

Patch attached moves the deletion call to the unconditionally executed
execute_after_dh_auto_build target, allowing us to also remove the
explicit call to dh_auto_test.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2025-12-10 11:31:07.017895263 -0800
--- b/debian/rules	2025-12-10 12:01:48.391513554 -0800
@@ -3,9 +3,8 @@
 %:
 	dh $@ --builddirectory=_build --buildsystem=golang
 
-override_dh_auto_test:
+execute_after_dh_auto_build:
 #=== RUN   ExampleCreateRequest_ParseResponse
 #2024/10/22 23:56:45 Post "https://freetsa.org/tsr": dial tcp: lookup freetsa.org on [::1]:53: read udp [::1]:59505->[::1]:53: read: connection refused
 #FAIL	github.com/digitorus/timestamp	0.011s
 	rm -f _build/src/github.com/digitorus/timestamp/timestamp_example_test.go
-	dh_auto_test $(DH_BUILD_OPTS)