Bug#840845: python-pygraphviz: FTBFS with /bin/sh as bash

[Chris Lamb]

Source: python-pygraphviz
Version: 1.3.1-1
Severity: serious
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-builds at lists.alioth.debian.org

Hi,

Due to the commented-out "set -e; \" line (note the trailing backslash!),
python-pygraphviz FTBFS when /bin/sh is bash.

Minimal patch attached. However, you should probably uncomment the set
-e bit and drop the leading - so that test failures actually cause a
FTBFS otherwise that's another bug IMHO.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
diff --git a/debian/rules b/debian/rules
index fcb04c5..f0e6a22 100755
--- a/debian/rules
+++ b/debian/rules
@@ -42,7 +42,7 @@ override_dh_installdocs:
 
 override_dh_auto_test:
 ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
-	#set -e; \
+	#set -e;
 	-for python in $(PYTHON2) $(PYTHON3); do \
 		echo "-- running tests for "$$python" plain --" ; \
 		LIB=$$($$python -c "from distutils.command.build import build ; from distutils.core import Distribution ; b = build(Distribution()) ; b.finalize_options() ; print (b.build_platlib)") ; \