[PATCH] reproducible Debian: filter Environment section from buildinfo files

[Mattia Rizzolo]

On Sun, Nov 06, 2016 at 04:05:12PM +0000, Holger Levsen wrote:
> On Sun, Nov 06, 2016 at 04:35:39PM +0100, Reiner Herrmann wrote:
> > +filter_buildinfo_files() {
> > +	# filters out the Environment section from buildinfo files
> > +	local TMPFILE1=$(mktemp --tmpdir=$TMPDIR)
> > +	grep-dctrl -I -s Environment . ./b1/$BUILDINFO > $TMPFILE1
> > +	mv $TMPFILE1 ./b1/$BUILDINFO
> 
> this permanently throws away the Environment information, which I'm not
> sure is the best case of action here. maybe we should preserve them
> both, always?

1) we never saved that information, so I don't see why starting now and
   to do it add a lot of complexity
2) personally, I don't see so much utility in that field (well, I do,
   just not enough to justify the work)
3) I'd rather see diffoscope deal with it as we'd like instead.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20161106/c51998fe/attachment.sig>