[PATCH] reproducible Debian: filter Environment section from buildinfo files

HW42 hw42 at ipsumj.de
Sun Nov 6 22:04:00 UTC 2016


Mattia Rizzolo:
> On Sun, Nov 06, 2016 at 04:05:12PM +0000, Holger Levsen wrote:
>> On Sun, Nov 06, 2016 at 04:35:39PM +0100, Reiner Herrmann wrote:
>>> +filter_buildinfo_files() {
>>> +	# filters out the Environment section from buildinfo files
>>> +	local TMPFILE1=$(mktemp --tmpdir=$TMPDIR)
>>> +	grep-dctrl -I -s Environment . ./b1/$BUILDINFO > $TMPFILE1
>>> +	mv $TMPFILE1 ./b1/$BUILDINFO
>>
>> this permanently throws away the Environment information, which I'm not
>> sure is the best case of action here. maybe we should preserve them
>> both, always?
> 
> 1) we never saved that information, so I don't see why starting now and
>    to do it add a lot of complexity
> 2) personally, I don't see so much utility in that field (well, I do,
>    just not enough to justify the work)
> 3) I'd rather see diffoscope deal with it as we'd like instead.

(As I wrote an hour ago on irc,) See last 3 commit at
https://anonscm.debian.org/git/users/hw42-guest/jenkins.debian.net.git/

  commit fdb7a50073ef9e3b8d22176b63817a78c928d73c
  Author: HW42 <hw42 at ipsumj.de>
  Date:   Sun Nov 6 18:30:46 2016 +0100
  
      reproducible Debian: always build under /build
      
      This way the build-path gets included into the .buildinfo like it will
      on buildds.
  
  commit 3c400e29acfa961e240986771159ff1d5637ebf0
  Author: HW42 <hw42 at ipsumj.de>
  Date:   Sun Nov 6 21:20:35 2016 +0100
  
      reproducible Debian: adapt for non identical .buildinfos
      
      .buildinfo document part of the build environment and are not expected
      to be the same for the two builds.
  
  commit fd2a54bfbe74e4593104f4c9df612d8b829de3d5
  Author: HW42 <hw42 at ipsumj.de>
  Date:   Sun Nov 6 21:59:47 2016 +0100
  
      reproducible Debian: vary the source dir name
      
      This hapens for example when some builders use 'dpkg-source -x' and others
      build out of a SCM.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 825 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20161106/f5a5e740/attachment.sig>


More information about the Reproducible-builds mailing list