Bug#850501: rerunning using diffoscope 67-21-gfe7ae15

[Chris Lamb]

Maria,

Thank you so much for these :)

> Added some tests for APK comparator, see attached patch.

Unfortunately I'm seeing:

differences = [<Difference zipinfo {} -- zipinfo {} []>, <Difference APK metadata -- APK metadata []>, <Difference AndroidManifest.xml -- AndroidManifest.xml []>, <Difference original/AndroidManifest.xml -- original/AndroidManifest.xml []>]

    @skip_unless_tools_exist('apktool', 'zipinfo')
    def test_android_manifest(differences):
>       assert differences[1].source1 == 'AndroidManifest.xml'
E       assert 'APK metadata' == 'AndroidManifest.xml'
E         - APK metadata
E         + AndroidManifest.xml

Any ideas?

> However, please keep in mind apktool takes a lot of time to run even on toy
> examples

Whilst I am not a fan of it slowing down this much, I think I'd
prefer to see some tests in there (that we can speed up later)
rather than none.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-