Bug#850501: rerunning using diffoscope 67-21-gfe7ae15

[Maria Glukhova]

Chris,

I see. Seems like file ordering differs for some reason. I should not have
relied on it, anyway.
Rewrote it so file ordering is not taken into account. Does it work now?

Thank you,
Maria

вс, 15 янв. 2017 г. в 2:43, Chris Lamb <lamby at debian.org>:

> Maria,
>
> Thank you so much for these :)
>
> > Added some tests for APK comparator, see attached patch.
>
> Unfortunately I'm seeing:
>
> differences = [<Difference zipinfo {} -- zipinfo {} []>, <Difference APK
> metadata -- APK metadata []>, <Difference AndroidManifest.xml --
> AndroidManifest.xml []>, <Difference original/AndroidManifest.xml --
> original/AndroidManifest.xml []>]
>
>     @skip_unless_tools_exist('apktool', 'zipinfo')
>     def test_android_manifest(differences):
> >       assert differences[1].source1 == 'AndroidManifest.xml'
> E       assert 'APK metadata' == 'AndroidManifest.xml'
> E         - APK metadata
> E         + AndroidManifest.xml
>
> Any ideas?
>
> > However, please keep in mind apktool takes a lot of time to run even on
> toy
> > examples
>
> Whilst I am not a fan of it slowing down this much, I think I'd
> prefer to see some tests in there (that we can speed up later)
> rather than none.
>
>
> Regards,
>
> --
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      lamby at debian.org / chris-lamb.co.uk
>        `-
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20170115/cc6b6dd9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-some-tests-for-APK-comarator.patch
Type: text/x-diff
Size: 7607 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20170115/cc6b6dd9/attachment.patch>