Bug#891867: diffoscope: improve .changes diffs

Chris Lamb lamby at debian.org
Thu Mar 1 21:00:27 UTC 2018


Hi Helmut!

Thanks for the report with patch :)

> --- a/diffoscope/comparators/debian.py
> +++ b/diffoscope/comparators/debian.py
> @@ -142,16 +142,16 @@
>          # Compare Files as string
>          if self.deb822.get('Files'):
>              differences.append(Difference.from_text(
> -                self.deb822.get_as_string('Files'),
> -                other.deb822.get_as_string('Files'),
> +                self.deb822.get_as_string('Files') + "\n",
> +                other.deb822.get_as_string('Files') + "\n",
>                  self.path,
>                  other.path,
>                  source='Files',
>              ))
>          else:
>              differences.append(Difference.from_text(
> -                self.deb822.get_as_string('Checksums-Sha256'),
> -                other.deb822.get_as_string('Checksums-Sha256'),
> +                self.deb822.get_as_string('Checksums-Sha256') + "\n",
> +                other.deb822.get_as_string('Checksums-Sha256') + "\n",

Why not .strip() them all instead, out of interest?

> Hi awesome reproducible team!

Aw, you know how to flatter us!


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-



More information about the Reproducible-builds mailing list